[BEAM-151] Add support for RunnableOnService validation tests to runners module #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers package Default implementation for Flink and Spark are to have it disabled. Default implementation for Dataflow requires you to specify the runnableOnServicePipelineOptions system property with a valid project/runner/... to be able to execute on Google Cloud Dataflow.
Member
Author
|
R: @davorbonaci Davor, after merge, please update Jenkins build: There -DrunnableOnServicePipelineOptions replaces -DdataflowOptions |
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>2.18.1</version> |
Member
There was a problem hiding this comment.
Version shouldn't be needed.
Member
|
LGTM |
Member
Author
|
@davorbonaci Did you perform the cleanups on merge? |
Member
|
Yup. |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
Add ModelEnforcements
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
dmvk
pushed a commit
to dmvk/beam
that referenced
this pull request
May 15, 2018
mareksimunek
pushed a commit
to seznam/beam
that referenced
this pull request
Jul 9, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Oct 5, 2018
damccorm
pushed a commit
that referenced
this pull request
Dec 9, 2022
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Dec 22, 2022
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.
Default implementation for Dataflow requires you to specify the runnableOnServicePipelineOptions
system property with a valid project/runner/... to be able to execute on Google Cloud Dataflow.
Default implementation for Flink and Spark are to have it disabled.
Note the whitespace formatting fix on spark pom.xml