-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-14446] Update some docs to point to GitHub issues #17594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #17594 +/- ##
=======================================
Coverage 74.01% 74.01%
=======================================
Files 695 695
Lines 91868 91872 +4
=======================================
+ Hits 67997 68001 +4
Misses 22625 22625
Partials 1246 1246
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
R: @aijamalnk |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
aijamalnk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's send a heads up email as a new thread on the dev list before merging? The last update didn't get any responses, so I wonder if people muted the thread.
| harder to roll back part of a commit. | ||
| * Commit messages should tag JIRAs and be otherwise descriptive. | ||
| It should later not be necessary to find a merge or first PR commit to find out what caused a change. | ||
| * Commit messages should be descriptive. It should later not be necessary to find a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should commit messages also reference the issue number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea - updated to this
Done! |
|
Run Java PreCommit |
|
Run Python_PVR_Flink PreCommit |
This PR updates all the docs we can update before migrating to GitHub issues. There are a number of links that will need to be updated after this PR completes to point to a newly migrated GitHub issue, but that can't happen until we run the migration tool.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.