[BEAM-14347] Update docs to prefer generic registration functions #17799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
…damccorm/registration-docs-2
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @youngoli for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
R: @lostluck |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
lostluck
requested changes
Jun 17, 2022
lostluck
reviewed
Jun 17, 2022
Contributor
Author
|
Thanks for the feedback, should be fixed. I think I wrote these before I introduced register.FunctionXxY, and forgot about that class of updates - thanks for calling it out! |
lostluck
approved these changes
Jun 29, 2022
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
One tiny change, but otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've proven out the effectiveness of the generic registration functions in #17613 and the 2.40 release is upon us, we should update the docs to recommend that approach.
✨ RENDERED ✨
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.