Skip to content

BigtableIO.Read: use PBegin, rather than PInput #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhalperi wants to merge 1 commit into from
Closed

BigtableIO.Read: use PBegin, rather than PInput #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdk/src/main/java/com/google/cloud/dataflow/sdk/io/bigtable/BigtableIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
import com.google.cloud.dataflow.sdk.transforms.PTransform;
import com.google.cloud.dataflow.sdk.util.DataflowReleaseInfo;
import com.google.cloud.dataflow.sdk.values.KV;
import com.google.cloud.dataflow.sdk.values.PBegin;
import com.google.cloud.dataflow.sdk.values.PCollection;
import com.google.cloud.dataflow.sdk.values.PDone;
import com.google.cloud.dataflow.sdk.values.PInput;
import com.google.common.base.MoreObjects;
import com.google.common.collect.ImmutableList;
import com.google.common.util.concurrent.FutureCallback;
Expand Down Expand Up @@ -176,7 +176,7 @@ public static Write write() {
* @see BigtableIO
*/
@Experimental
public static class Read extends PTransform<PInput, PCollection<Row>> {
public static class Read extends PTransform<PBegin, PCollection<Row>> {
/**
* Returns a new {@link BigtableIO.Read} that will read from the Cloud Bigtable cluster
* indicated by the given options, and using any other specified customizations.
Expand Down Expand Up @@ -241,14 +241,14 @@ public String getTableId() {
}

@Override
public PCollection<Row> apply(PInput input) {
public PCollection<Row> apply(PBegin input) {
BigtableSource source =
new BigtableSource(getBigtableService(), tableId, filter, ByteKeyRange.ALL_KEYS, null);
return input.getPipeline().apply(com.google.cloud.dataflow.sdk.io.Read.from(source));
}

@Override
public void validate(PInput input) {
public void validate(PBegin input) {
checkArgument(options != null, "BigtableOptions not specified");
checkArgument(!tableId.isEmpty(), "Table ID not specified");
try {
Expand Down