Integration fixes #189
Closed
Integration fixes #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
----Release Notes---- [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=119217803
Contributor
Author
|
A partial forward-port from https://github.com/GoogleCloudPlatform/DataflowJavaSDK/pull/202/files |
Contributor
|
I think at least some of the fixes have already been merged. Can you confirm that this is necessary, and if so resolve the conflicts? |
Contributor
Author
|
@bjchambers : The fixes were not merged, but rather completely differently implemented by you and scott. This is to normalize them. |
Contributor
Author
|
Closing because they have now been merged in as part of #126 |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
Backport debugger changes
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-local] fix findbug warning regarding random reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a testing difference between DataflowJavaSDK and Beam copies of the code that was lost in a recent code change.