Clean up DataflowPipeline[Debug]Options #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @davorbonaci |
tgroh
force-pushed
the
remove_deprecated_debug_options
branch
from
d596ea5 to
f2287b7
Compare
Member
|
LGTM. R: @lukecwik for a second look on getX vs. isX with PipelineOptions. |
getUpdate should be isUpdate, to meet standard JavaBeans style. Remove deprecated update property from DataflowPipelineDebugOptions
tgroh
force-pushed
the
remove_deprecated_debug_options
branch
from
f2287b7 to
af3ccef
Compare
Member
|
LGTM is and get are the same for boolean properties as per javabeans |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
Fix multithreaded visibility issue with TransformExecutor
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-core] DataSinkWrapper is now Serializable
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Toward apache#92. Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
getUpdate should be isUpdate, to meet standard JavaBeans style.
Remove deprecated update property from DataflowPipelineDebugOptions