-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Go SDK] Add more info to Worker Status API #21776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #21776 +/- ##
==========================================
- Coverage 74.09% 74.07% -0.03%
==========================================
Files 698 698
Lines 92503 92574 +71
==========================================
+ Hits 68544 68577 +33
- Misses 22704 22742 +38
Partials 1255 1255
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Run GoPortable PostCommit |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
|
||
| import ( | ||
| "context" | ||
| "regexp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this change. At best, we mostly want to remove the blank line between "strings" and "fmt".
|
|
||
| // Main is the main entrypoint for the Go harness. It runs at "runtime" -- not | ||
| // "pipeline-construction time" -- on each worker. It is a FnAPI client and | ||
| // ultimately responsible for correctly executing user code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add documentation around "expected" Environment variables. TBH, I don't mind the options approach to pass into main, but the fetching form the Env vars would then happen in the init.go.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Go Postcommit |
|
Made the changes, PTAL |
|
Run Go PostCommit |
Adds Memory Usage information, Cache Stats, and Active Process Bundle States to worker status API added in #16957
Example Output (on Dataflow):
See the bottom of https://docs.google.com/document/d/1dMTD5_sKdzLcnoe0ZsQU5Wf9q11uliyYgFnnOZQDzuI/ for more details.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.