Skip to content

Conversation

@ihji
Copy link
Contributor

@ihji ihji commented Jun 9, 2022

#21780


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ihji
Copy link
Contributor Author

ihji commented Jun 9, 2022

R: @chamikaramj

@robertwb
Copy link
Contributor

I don't think this is the right direction either. If an external transform needs a certain set of files, that transform should be responsible for making the declaration, not the callee (and especially, it seems, the callee from another language).

I think the correct solution is to us resource hints (e.g. https://beam.apache.org/documentation/runtime/resource-hints/). There's also the issue of finding the resources at their new locations (on the worker). Presumably one would ask for a resource (e.g. file) to be staged against some kind of identifier, and on the worker one could use this identifier to look up the copied resource in its final destination.

@ihji
Copy link
Contributor Author

ihji commented Jun 10, 2022

I'm not sure resource hint is the right tool for this. From what I've read from the proto definition, resource hint is advisory (nice to have) and can be ignored by runners. However, the resource here is considered as one of the inputs of the expanded transform (must have) and should not be ignored (otherwise the transform will certainly fail). The staged resources are more like runtime dependencies not just hints.

I agree that it would be great if we could look up staged resources by identifiers.

@ihji ihji closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants