Skip to content

Conversation

@chamikaramj
Copy link
Contributor

…transforms

This fixes #21787


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@chamikaramj
Copy link
Contributor Author

R: @robertwb

@chamikaramj
Copy link
Contributor Author

Run XVR_Dataflow PostCommit

@chamikaramj
Copy link
Contributor Author

Dataflow CrossLanguageValidatesRunner PythonUsingJava Tests

@chamikaramj
Copy link
Contributor Author

Dataflow CrossLanguageValidatesRunner JavaUsingPython Tests

@robertwb robertwb changed the title Automatically enable Runner v2 for pipelines that use cross-language … Automatically enable Runner v2 for pipelines that use cross-language transforms. Jun 10, 2022
LOG.info(
"Automatically enabling Dataflow Runner v2 since the pipeline used cross-language"
+ "transforms");
experiments.add("use_runner_v2");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to add portable_job_submission as well, or is that not automatic for all Java pipelines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's automatic for all Java UW pipelines:

@robertwb
Copy link
Contributor

Note that Jenkis is currently down, see https://issues.apache.org/jira/browse/INFRA-23358

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #21788 (b8e2e85) into master (f131b2d) will increase coverage by 0.14%.
The diff coverage is 84.39%.

❗ Current head b8e2e85 differs from pull request most recent head efbce54. Consider uploading reports for the commit efbce54 to get more accurate results

@@            Coverage Diff             @@
##           master   #21788      +/-   ##
==========================================
+ Coverage   74.00%   74.15%   +0.14%     
==========================================
  Files         698      698              
  Lines       92224    92411     +187     
==========================================
+ Hits        68253    68530     +277     
+ Misses      22720    22630      -90     
  Partials     1251     1251              
Flag Coverage Δ
go 50.93% <ø> (ø)
python 83.77% <84.39%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thon/apache_beam/ml/inference/pytorch_inference.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/utils/counters.py 85.39% <66.66%> (-1.36%) ⬇️
...on/apache_beam/runners/direct/sdf_direct_runner.py 35.53% <75.00%> (ø)
...eam/transforms/py_dataflow_distribution_counter.py 91.42% <75.00%> (-4.87%) ⬇️
sdks/python/apache_beam/transforms/cy_combiners.py 62.90% <76.00%> (+4.50%) ⬆️
sdks/python/apache_beam/runners/common.py 88.68% <83.33%> (+0.74%) ⬆️
sdks/python/apache_beam/transforms/core.py 92.38% <90.47%> (+0.23%) ⬆️
sdks/python/apache_beam/typehints/batch.py 87.09% <94.11%> (+0.86%) ⬆️
sdks/python/apache_beam/ml/inference/base.py 95.06% <96.66%> (+1.36%) ⬆️
...thon/apache_beam/ml/inference/sklearn_inference.py 93.33% <97.05%> (+0.83%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f131b2d...efbce54. Read the comment docs.

@chamikaramj chamikaramj force-pushed the auto_add_runner_v2_experiment branch from 0368ea9 to efbce54 Compare June 11, 2022 17:15
@chamikaramj
Copy link
Contributor Author

Retest this please

@chamikaramj
Copy link
Contributor Author

Run Java PreCommit

@chamikaramj
Copy link
Contributor Author

Dataflow CrossLanguageValidatesRunner PythonUsingJava Tests

@chamikaramj
Copy link
Contributor Author

Dataflow CrossLanguageValidatesRunner JavaUsingPython Tests

@chamikaramj
Copy link
Contributor Author

Run Java PreCommit

@chamikaramj
Copy link
Contributor Author

Run Java PostCommit

@chamikaramj
Copy link
Contributor Author

Run Java PreCommit

@chamikaramj
Copy link
Contributor Author

(failures are unrelated)

@chamikaramj
Copy link
Contributor Author

Run Java PreCommit

@chamikaramj
Copy link
Contributor Author

Only failing test is "org.apache.beam.runners.flink.batch.ReshuffleTest.testEqualDistributionOnReshuffleAcrossMultipleStages" which is completed unrelated.

https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/5235/

@chamikaramj chamikaramj merged commit e7c021d into apache:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Automatically upgrade Dataflow Java pipelines that use cross-language transforms to Runner v2

2 participants