-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Automatically enable Runner v2 for pipelines that use cross-language transforms. #21788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically enable Runner v2 for pipelines that use cross-language transforms. #21788
Conversation
|
R: @robertwb |
|
Run XVR_Dataflow PostCommit |
|
Dataflow CrossLanguageValidatesRunner PythonUsingJava Tests |
|
Dataflow CrossLanguageValidatesRunner JavaUsingPython Tests |
| LOG.info( | ||
| "Automatically enabling Dataflow Runner v2 since the pipeline used cross-language" | ||
| + "transforms"); | ||
| experiments.add("use_runner_v2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to add portable_job_submission as well, or is that not automatic for all Java pipelines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's automatic for all Java UW pipelines:
Line 1055 in b8e2e85
| experiments.add("use_portable_job_submission"); |
|
Note that Jenkis is currently down, see https://issues.apache.org/jira/browse/INFRA-23358 |
Codecov Report
@@ Coverage Diff @@
## master #21788 +/- ##
==========================================
+ Coverage 74.00% 74.15% +0.14%
==========================================
Files 698 698
Lines 92224 92411 +187
==========================================
+ Hits 68253 68530 +277
+ Misses 22720 22630 -90
Partials 1251 1251
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0368ea9 to
efbce54
Compare
|
Retest this please |
|
Run Java PreCommit |
|
Dataflow CrossLanguageValidatesRunner PythonUsingJava Tests |
|
Dataflow CrossLanguageValidatesRunner JavaUsingPython Tests |
|
Run Java PreCommit |
|
Run Java PostCommit |
|
Run Java PreCommit |
|
(failures are unrelated) |
|
Run Java PreCommit |
|
Only failing test is "org.apache.beam.runners.flink.batch.ReshuffleTest.testEqualDistributionOnReshuffleAcrossMultipleStages" which is completed unrelated. https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/5235/ |
…transforms
This fixes #21787
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.