Skip to content

Replace SklearnModelLoader with SklearnModelHandler #21805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertwb merged 1 commit into from
Jun 10, 2022
Merged

Replace SklearnModelLoader with SklearnModelHandler #21805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdks/python/apache_beam/ml/inference/sklearn_inference_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def test_pipeline_pandas(self):
splits = [dataframe.loc[[i]] for i in dataframe.index]
pcoll = pipeline | 'start' >> beam.Create(splits)
actual = pcoll | api.RunInference(
SklearnModelLoader(model_uri=temp_file_name))
SklearnModelHandler(model_uri=temp_file_name))

expected = [
api.PredictionResult(splits[0], 5),
Expand All @@ -265,7 +265,7 @@ def test_pipeline_pandas_with_keys(self):

pcoll = pipeline | 'start' >> beam.Create(keyed_rows)
actual = pcoll | api.RunInference(
SklearnModelLoader(model_uri=temp_file_name))
SklearnModelHandler(model_uri=temp_file_name))
expected = [
('0', api.PredictionResult(splits[0], 5)),
('1', api.PredictionResult(splits[1], 8)),
Expand All @@ -279,14 +279,14 @@ def test_pipeline_pandas_with_keys(self):
def test_infer_invalid_data_type(self):
with self.assertRaises(ValueError):
unexpected_input_type = [[1, 2, 3, 4], [5, 6, 7, 8]]
inference_runner = SklearnModelLoader(model_uri=unused)
inference_runner = SklearnModelHandler(model_uri='unused')
fake_model = FakeModel()
inference_runner.run_inference(unexpected_input_type, fake_model)

def test_infer_too_many_rows_in_dataframe(self):
with self.assertRaises(ValueError):
data_frame_too_many_rows = pandas_dataframe()
inference_runner = SklearnModelLoader(model_uri=unused)
inference_runner = SklearnModelHandler(model_uri='unused')
fake_model = FakeModel()
inference_runner.run_inference([data_frame_too_many_rows], fake_model)

Expand Down