Sharding IO tests(amazon web services and amazon web services 2) from java post commit task #21808
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
R: @mosche |
| ], // spotless checked in separate pre-commit | ||
| triggerPathPatterns: [ | ||
| '^sdks/java/io/amazon-web-services/.*$', | ||
| '^runners/direct-java/.*$', |
There was a problem hiding this comment.
Remove this trigger path too.
| ], // spotless checked in separate pre-commit | ||
| triggerPathPatterns: [ | ||
| '^sdks/java/io/amazon-web-services2/.*$', | ||
| '^runners/direct-java/.*$', |
There was a problem hiding this comment.
We do not need to run these tests when the direct runner is modified, since these tests are not for checking the correctness of the direct runner. So should remove this trigger path.
|
LGTM other than that. I do think it will be good to separate the tasks. |
|
Hi @kennknowles |
…Amazon-web-services-2)-from-JavaPostCommit-task
build.gradle.kts
Outdated
| dependsOn(":sdks:java:io:google-cloud-platform:postCommit") | ||
| dependsOn(":sdks:java:io:amazon-web-services:integrationTest") | ||
| dependsOn(":sdks:java:io:amazon-web-services2:integrationTest") | ||
| dependsOn(":sdks:java:io:kinesis:integrationTest") |
There was a problem hiding this comment.
I think is related to a merge conflict with other branch that is working in the tests. Let me talk about it with the team and do the changes.
|
I suggest doing a |
|
@andoni-guzman wondering, should this be using the PostcommitJobBuilder, or is it intentional to have it as a precommit job from now on? |
|
Andoni & I talked about it, and I think since it only triggers when the IO itself is being modified, and it is pretty small, that it could be OK to be presubmit. |
|
I suppose the possible reason not to would be if iterating in the PR causes a lot of not-useful builds that create large cost on a real cloud. But I think it will be barely measurable difference |
|
Hi @kennknowles, |
kennknowles
left a comment
kennknowles
left a comment
There was a problem hiding this comment.
LGTM but needs yet another rebase since there is a conflict with master
5 participants
Sharding IO tests Amazon web services and Amazon web services 2 from Java PostCommit task
Looking to reduce JavaPostCommit task some test were split in different ones. This PR is for Amazon web services and Amazon web services 2 tests.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.