[#21761] Add GCP Project as pipeline opt read by expansion service #21852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Run XVR_GoUsingJava_Dataflow PostCommit |
Contributor
Author
|
R: @chamikaramj |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
This seems like the best approach would be to have this extra pipeline option only read while using the GCP expansion service, but I'm not sure if there's a straightforward way to alter the behavior only when using that expansion service |
chamikaramj
reviewed
Jun 14, 2022
chamikaramj
reviewed
Jun 14, 2022
.../expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I've changed it so that now GcpExpansionService is a derived class of the original ExpansionService, and only that class receives the project pipeline option. So only the GCP expansion service jar has grown. |
Contributor
Author
|
Run Go PostCommit |
Contributor
Author
|
Run XVR_GoUsingJava_Dataflow PostCommit |
Contributor
Author
|
Looks like the test is still failing, which means my local environment isn't replicating the bug. I'll look into this tomorrow. |
Contributor
Author
|
Run XVR_GoUsingJava_Dataflow PostCommit |
1 similar comment
Contributor
Author
|
Run XVR_GoUsingJava_Dataflow PostCommit |
The expansion service now reads the Project pipeline option so that during expansion it can perform GCP operations on the correct project. Also un-sickbay a test that was blocked on this issue.
This makes some changes to ExpansionService.java to allow performing additional configuration in subclasses.
Contributor
Author
|
Run XVR_GoUsingJava_Dataflow PostCommit |
2 similar comments
Contributor
|
Run XVR_GoUsingJava_Dataflow PostCommit |
Contributor
|
Run XVR_GoUsingJava_Dataflow PostCommit |
Contributor
|
Looks like it still fails to get the projectID, but it could be just in how the Go SDK is providing it in pipeline options (or not).
|
Contributor
Contributor
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
Contributor
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expansion service now reads the Project pipeline option so that during expansion it can perform GCP operations on the correct project. Also un-sickbay a test that was blocked on this issue.
Bug: #21761
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.