Fix how this SDK identifies itself to the Cloud Dataflow service #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Beam SDK naming, instead of Dataflow SDK. * Fix version lookup, so it correctly identifies the version.
| private static final Logger LOG = LoggerFactory.getLogger(DataflowReleaseInfo.class); | ||
|
|
||
| private static final String DATAFLOW_PROPERTIES_PATH = | ||
| "/org.apache.beam/sdk/sdk.properties"; |
Member
There was a problem hiding this comment.
Please rename file to BeamReleaseInfo or just ReleaseInfo
Member
Author
|
PTAL. |
Member
|
LGTM Would be better with test since would have caught the original break. |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @lukecwik