-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Don't try to parse non-flags as retained pipeline options. #22276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @ahmedabu98 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Flake in PortableRunnerTestWithSubprocesses.test_pardo_timers |
|
Run Python PreCommit |
Codecov Report
@@ Coverage Diff @@
## master #22276 +/- ##
==========================================
- Coverage 74.26% 74.24% -0.02%
==========================================
Files 702 702
Lines 93019 93022 +3
==========================================
- Hits 69076 69066 -10
- Misses 22676 22689 +13
Partials 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| if not unknown_args[i].startswith('-'): | ||
| i += 1 | ||
| continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we start looking at i+1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will look at i+1, which will be a fresh argument, in the next iteration of the loop.
|
Left one comment, otherwise LGTM! |
This can happen if a user passes flags like --foo --bar some_non_flag_arg.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.