Pass user specified destination type to UpdateSchemaDestination #22624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use it in UpdateSchemaDestinations
Contributor
Author
|
Run PostCommit_Java_DataflowV2 |
Contributor
Author
|
R: @johnjcasey |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
Run PostCommit_Java_DataflowV2 |
Contributor
|
This LGTM. Have you retried the original failing custom dynamic destinations? |
Contributor
Author
|
Yup, left a comment in #22543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22543
When using multiple partitions for a BigQuery
FILE_LOADSwrite, the user's dynamic destination type isn't properly passed intoUpdateSchemaDestination. This leads to aClassCastExceptionwhen attempting to get the table and schema using the dynamic destination object.The user's dynamic destination object is configured with a particular parameter type (represented by
DestinationT) forgetTable()andgetSchema(see here). The current implementation from #17365 doesn't respect this user type and instead passes in a fixed TableDestination argument.