Skip to content

Conversation

@AnandInguva
Copy link
Contributor

Fixes: #21859

Accidentaly, Sklearn IT test got skipped at #22088. Unskip and run it in the postcommit 37 and 39 suite


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@AnandInguva
Copy link
Contributor Author

Run Python 3.7 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.9 PostCommit

@AnandInguva
Copy link
Contributor Author

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #22825 (dce531d) into master (c7938fa) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22825      +/-   ##
==========================================
- Coverage   73.98%   73.98%   -0.01%     
==========================================
  Files         713      713              
  Lines       94048    94048              
==========================================
- Hits        69582    69579       -3     
- Misses      23180    23183       +3     
  Partials     1286     1286              
Flag Coverage Δ
python 83.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/internal/metrics/metric.py 93.00% <0.00%> (-1.00%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also unskip pytorch tests? I'm unclear on if they're running somewhere https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/inference/pytorch_inference_it_test.py#L63-L67

This still LGTM though, will merge when we get a green CI run

@TheNeuralBit
Copy link
Member

Run Python_PVR_Flink PreCommit

@TheNeuralBit
Copy link
Member

Run Python 3.7 PostCommit

@TheNeuralBit
Copy link
Member

Run Python 3.9 PostCommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unskip RunInference IT tests once the licensing on the datasets and models is complete.

3 participants