-
Notifications
You must be signed in to change notification settings - Fork 4.5k
unskip sklearn IT test #22825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unskip sklearn IT test #22825
Conversation
|
Run Python 3.7 PostCommit |
|
Run Python 3.9 PostCommit |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #22825 +/- ##
==========================================
- Coverage 73.98% 73.98% -0.01%
==========================================
Files 713 713
Lines 94048 94048
==========================================
- Hits 69582 69579 -3
- Misses 23180 23183 +3
Partials 1286 1286
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TheNeuralBit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also unskip pytorch tests? I'm unclear on if they're running somewhere https://github.com/apache/beam/blob/master/sdks/python/apache_beam/ml/inference/pytorch_inference_it_test.py#L63-L67
This still LGTM though, will merge when we get a green CI run
|
Run Python_PVR_Flink PreCommit |
|
Run Python 3.7 PostCommit |
|
Run Python 3.9 PostCommit |
Fixes: #21859
Accidentaly, Sklearn IT test got skipped at #22088. Unskip and run it in the postcommit 37 and 39 suite
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.