Skip to content

[BEAM-168] Remove uses of deprecated API #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhalperi wants to merge 1 commit into from
Closed

[BEAM-168] Remove uses of deprecated API #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/java/core/src/main/java/org/apache/beam/sdk/io/BoundedReadFromUnboundedSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public boolean advance() throws IOException {

private boolean advanceWithBackoff() throws IOException {
// Try reading from the source with exponential backoff
BackOff backoff = new IntervalBoundedExponentialBackOff(10000, 10);
BackOff backoff = new IntervalBoundedExponentialBackOff(10000L, 10L);
long nextSleep = backoff.nextBackOffMillis();
while (nextSleep != BackOff.STOP) {
if (endTime != null && Instant.now().isAfter(endTime)) {
Expand Down
10 changes: 5 additions & 5 deletions ...va/core/src/test/java/org/apache/beam/sdk/util/IntervalBoundedExponentialBackOffTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ public class IntervalBoundedExponentialBackOffTest {
public void testUsingInvalidInitialInterval() throws Exception {
exception.expect(IllegalArgumentException.class);
exception.expectMessage("Initial interval must be greater than zero.");
new IntervalBoundedExponentialBackOff(1000, 0L);
new IntervalBoundedExponentialBackOff(1000L, 0L);
}

@Test
public void testUsingInvalidMaximumInterval() throws Exception {
exception.expect(IllegalArgumentException.class);
exception.expectMessage("Maximum interval must be greater than zero.");
new IntervalBoundedExponentialBackOff(-1, 10L);
new IntervalBoundedExponentialBackOff(-1L, 10L);
}

@Test
public void testThatcertainNumberOfAttemptsReachesMaxInterval() throws Exception {
IntervalBoundedExponentialBackOff backOff = new IntervalBoundedExponentialBackOff(1000, 500);
IntervalBoundedExponentialBackOff backOff = new IntervalBoundedExponentialBackOff(1000L, 500);
assertThat(backOff.nextBackOffMillis(), allOf(greaterThanOrEqualTo(249L), lessThan(751L)));
assertThat(backOff.nextBackOffMillis(), allOf(greaterThanOrEqualTo(374L), lessThan(1126L)));
assertThat(backOff.nextBackOffMillis(), allOf(greaterThanOrEqualTo(500L),
Expand All @@ -70,7 +70,7 @@ public void testThatcertainNumberOfAttemptsReachesMaxInterval() throws Exception

@Test
public void testThatResettingAllowsReuse() throws Exception {
IntervalBoundedExponentialBackOff backOff = new IntervalBoundedExponentialBackOff(1000, 500);
IntervalBoundedExponentialBackOff backOff = new IntervalBoundedExponentialBackOff(1000L, 500);
assertThat(backOff.nextBackOffMillis(), allOf(greaterThanOrEqualTo(249L), lessThan(751L)));
assertThat(backOff.nextBackOffMillis(), allOf(greaterThanOrEqualTo(374L), lessThan(1126L)));
assertThat(backOff.nextBackOffMillis(), allOf(greaterThanOrEqualTo(500L),
Expand All @@ -88,7 +88,7 @@ public void testThatResettingAllowsReuse() throws Exception {

@Test
public void testAtMaxInterval() throws Exception {
IntervalBoundedExponentialBackOff backOff = new IntervalBoundedExponentialBackOff(1000, 500);
IntervalBoundedExponentialBackOff backOff = new IntervalBoundedExponentialBackOff(1000L, 500);
assertFalse(backOff.atMaxInterval());
backOff.nextBackOffMillis();
assertFalse(backOff.atMaxInterval());
Expand Down