Disable singleIterate #23042
Merged
Disable singleIterate #23042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Run Go Spark ValidatesRunner |
Contributor
Author
|
Run Go Spark ValidatesRunner |
Contributor
Author
jrmccluskey
approved these changes
Sep 6, 2022
Contributor
jrmccluskey
left a comment
jrmccluskey
left a comment
There was a problem hiding this comment.
LGTM mod final test runs
Codecov Report
@@ Coverage Diff @@
## master #23042 +/- ##
==========================================
- Coverage 73.67% 73.64% -0.04%
==========================================
Files 714 714
Lines 95212 95213 +1
==========================================
- Hits 70150 70119 -31
- Misses 23765 23798 +33
+ Partials 1297 1296 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the singleIterate efficiency improvement introduced in #22904 because there have been reports of it breaking pipelines. I chose not to revert because it can't be automatically reverted due to other PRs layered on top, so this is the minimal change required to disable the feature.
This should also stop tests from failing as reported in #22933 (though I think we should leave it open until this is more permanently disabled)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.