Skip to content

Conversation

@mosche
Copy link
Member

@mosche mosche commented Sep 13, 2022

Annotate stateful VR test in TestStreamTest with UsesStatefulParDo for #22620 (#22472).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Sep 13, 2022
@mosche
Copy link
Member Author

mosche commented Sep 13, 2022

R: @kennknowles

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@mosche
Copy link
Member Author

mosche commented Sep 13, 2022

R: @echauchot
R: @aromanenko-dev
(tiny PR to fix a VR test annotation)

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aromanenko-dev aromanenko-dev merged commit ebacef9 into apache:master Sep 13, 2022
@mosche mosche deleted the 22472-VR-TestStreamTest-Annotation branch September 13, 2022 12:59
@kennknowles
Copy link
Member

FWIW I just meant to have this as a separate commit in the same PR. We do not require PRs to be squashed, so I could create a merge commit that would preserve them separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants