Replace more uses of ClassLoadingStrategy.Default.INJECTION
#23210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @kileys |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
cushon
force-pushed
the
ClassLoadingStrategy
branch
from
5b638cb to
f49fc3a
Compare
Contributor
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
Contributor
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
kileys
reviewed
Jan 11, 2023
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java
Outdated
Show resolved
Hide resolved
Contributor
cushon
force-pushed
the
ClassLoadingStrategy
branch
from
f49fc3a to
3340d37
Compare
lukecwik
requested changes
Feb 10, 2023
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteBuddyUtils.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteBuddyUtils.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteBuddyUtils.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
Outdated
Show resolved
Hide resolved
lukecwik
reviewed
Feb 10, 2023
sdks/java/core/src/main/java/org/apache/beam/sdk/util/ByteBuddyUtils.java
Outdated
Show resolved
Hide resolved
cushon
force-pushed
the
ClassLoadingStrategy
branch
from
f4626ee to
c953fe5
Compare
lukecwik
approved these changes
Feb 13, 2023
in preparation for Java 17+. Follow-up to: apache@98f1f75.
Co-authored-by: Lukasz Cwik <lcwik@google.com>
…yUtils.java Co-authored-by: Lukasz Cwik <lcwik@google.com>
lukecwik
approved these changes
Feb 14, 2023
Member
|
Run Java_Kafka_IO_Direct PreCommit |
Member
|
Run Java PreCommit |
Member
|
Run Java_Cdap_IO_Direct PreCommit |
Member
|
Run Java_Hadoop_IO_Direct PreCommit |
Member
|
Run Java PreCommit |
Member
|
Run Java_Kafka_IO_Direct PreCommit |
1 similar comment
Member
|
Run Java_Kafka_IO_Direct PreCommit |
Abacn
added a commit
to Abacn/beam
that referenced
this pull request
Feb 20, 2023
…apache#23210)" This reverts commit 2b62912.
3 tasks
3 tasks
ruslan-ikhsan
pushed a commit
to akvelon/beam
that referenced
this pull request
Mar 10, 2023
…apache#23210)" (apache#25566) This reverts commit 2b62912.
cushon
added a commit
to cushon/beam
that referenced
this pull request
Apr 20, 2023
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
cushon
added a commit
to cushon/beam
that referenced
this pull request
Apr 20, 2023
* revert a change to the classloader used in RowCoderGenerator (apache#23210 (comment)) * don't use the lookup strategy for built-in JDK classes
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation for Java 17+.
See "Supporting proxies on Java versions prior to 9 and past 10" in http://mydailyjava.blogspot.com/2018/04/jdk-11-and-proxies-in-world-past.html
Follow-up to: 98f1f75.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.