-
Notifications
You must be signed in to change notification settings - Fork 4.5k
GA migration and sharding Python Postcommit ML #23312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9bd7aa0
Migrate and sharding Python Postcommit ML from Jenkins to GA
benEng bba8de5
Change from self-hosted to [self-hosted, ubuntu-20.04]
benEng 03f7983
Adding workflow dispatch and update CI.md
benEng 3a5e6be
Remove submodules: recursive and set fail-fast: false
benEng 3d22da0
Update CI.md
benEng e418fce
Add torchInferenceTest to ML workflow
benEng 5ed6f86
Merge branch 'ga-postcommit-ml' of github.com:benWize/beam into ga-po…
benEng 0bc2df2
Change torchinferenceTest to inferencePostCommitIT to include sklearn…
benEng b33b230
Setup service account with action
benEng f246744
Merge branch 'master' into ga-postcommit-ml
benEng 6169840
Merge branch 'ga-postcommit-ml' of github.com:benWize/beam into ga-po…
benEng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # This workflow will run the tests of python ML with DataflowRunner. | ||
|
|
||
| name: PostCommit Python ML | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 */6 * * *' | ||
| push: | ||
| branches: ['master', 'release-*'] | ||
| tags: ['v*'] | ||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| set-properties: | ||
| runs-on: self-hosted | ||
| outputs: | ||
| properties: ${{ steps.test-properties.outputs.properties }} | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| persist-credentials: false | ||
| - id: test-properties | ||
| uses: ./.github/actions/setup-default-test-properties | ||
|
|
||
| python_ml: | ||
| needs: set-properties | ||
| name: Python ML | ||
| runs-on: [self-hosted, ubuntu-20.04] | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| version: ${{fromJson(needs.set-properties.outputs.properties).PythonTestProperties.ALL_SUPPORTED_VERSIONS}} | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Setup service account | ||
| uses: ./.github/actions/activate-service-account | ||
| with: | ||
| GCP_SERVICE_ACCOUNT: ${{secrets.GCP_SELF_HOSTED_SA_KEY}} | ||
| - name: Set python version | ||
| run: echo "PYTHON_VERSION=$(echo ${{ matrix.version }} | sed -e 's/\.//g')" >> $GITHUB_ENV | ||
| - name: Setup environment | ||
| uses: ./.github/actions/setup-self-hosted-action | ||
| with: | ||
| requires-go-18: false | ||
| - name: Run :sdks:python:test-suites:dataflow:py${{env.PYTHON_VERSION}}:postCommitITByTestDirectory | ||
| uses: ./.github/actions/gradle-command-self-hosted-action | ||
| with: | ||
| gradle-command: :sdks:python:test-suites:dataflow:py${{env.PYTHON_VERSION}}:postCommitITByTestDirectory | ||
| arguments: "-PtestDir=apache_beam/ml" | ||
| - name: Run :sdks:python:test-suites:direct:py${{env.PYTHON_VERSION}}:inferencePostCommitIT | ||
| uses: ./.github/actions/gradle-command-self-hosted-action | ||
| with: | ||
| gradle-command: :sdks:python:test-suites:direct:py${{env.PYTHON_VERSION}}:inferencePostCommitIT | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pytorch tests in apache_beam/ml/inference will get skipped because the dependencies won't be installed[1] on the runner with this workflow.
beam/sdks/python/test-suites/direct/common.gradle
Line 193 in 0448f2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an extra step to run the Gradle task
torchInferenceTestThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnandInguva is that enough to make this work? Do we need to do the same thing for other frameworks (e.g. sklearn?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be sufficient to run the current ML tests