Skip to content

Support google-cloud-spanner v3 and fixes broken unit tests #23365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvalentyn merged 5 commits into from
Sep 28, 2022
Merged

Support google-cloud-spanner v3 and fixes broken unit tests #23365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9395a96
Python SpannerIO Fixes
Abacn Sep 25, 2022
eb87d9c
Fix test_harness_monitoring_infos_and_metadata actually clear metrics
Abacn Sep 25, 2022
0a7fff4
Set google-cloud-spanner major version upper bound
Abacn Sep 28, 2022
5b42e71
Test pinning google-cloud-spanner version 3
Abacn Sep 28, 2022
55cc71e
Revert "Test pinning google-cloud-spanner version 3"
Abacn Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sdks/python/apache_beam/io/gcp/experimental/spannerio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,12 @@ class _Mutator(namedtuple('_Mutator',

@property
def byte_size(self):
return self.mutation.ByteSize()
if hasattr(self.mutation, '_pb'):
# google-cloud-spanner 3.x
return self.mutation._pb.ByteSize()
else:
# google-cloud-spanner 1.x
return self.mutation.ByteSize()


class MutationGroup(deque):
Expand Down
Loading