-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add database role to SpannerConfig for role-based access control. #23377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
LGTM |
|
R: @pabloem |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
darshan-sj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #23377 +/- ##
========================================
Coverage 73.45% 73.46%
========================================
Files 718 718
Lines 95770 95935 +165
========================================
+ Hits 70352 70475 +123
- Misses 24107 24149 +42
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
lgtm. I'll merge once we get clean tests. |
Please add a meaningful description for your change here
Propagate database role for fine-grained access control in Cloud Spanner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.