-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Bump google-cloud-spanner version for py containers #23480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Python 3.7 PostCommit |
|
R: @tvalentyn |
|
Trigger phrase seems not working |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #23480 +/- ##
==========================================
- Coverage 73.45% 73.44% -0.01%
==========================================
Files 718 718
Lines 95878 95876 -2
==========================================
- Hits 70425 70420 -5
- Misses 24142 24145 +3
Partials 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4b7f358 to
c370fe9
Compare
| google-cloud-pubsublite==1.5.0 | ||
| google-cloud-recommendations-ai==0.7.1 | ||
| google-cloud-spanner==1.19.3 | ||
| google-cloud-spanner==3.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail with:
09:43:29 google-cloud-spanner 3.22.0 requires sqlparse, which is not installed.
these files need to be regenerated (see header at the top of the file).
Also, I think it would be safer to set the upper bound >=3.0.0 in setup.py.
|
Having issues on running Seems like it only supports linux. Needs a linux machine to run the script. Also, found google-python-cloud-debugger is set to shutdown by May 31,2023: https://cloud.google.com/debugger/docs/release-notes entered #23487 |
sdks/python/setup.py
Outdated
| # google-cloud-spanner 2.x causes dependency parsing backoff | ||
| 'google-cloud-spanner>=1.13.0,!=2,<4', | ||
| 'google-cloud-spanner>=3.0.0,<4', | ||
| 'grpcio-gcp>=0.2.2,<1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is also a spanner v1 dep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, introduced in #9606. Will remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reran generate requirements
|
Run Python_PVR_Flink PreCommit |
|
Run Python 3.7 PostCommit |
|
postcommit test run out of quota again: "Workflow failed. Causes: Project apache-beam-testing has insufficient quota(s) to execute this workflow with 1 instances in region us-central1. Quota summary (required/available): 1/38753 instances, 2/1210 CPUs, 25/344105 disk GB, 0/758 SSD disk GB, 1/271 instance groups, 1/274 managed instance groups, 1/468 instance templates, 1/0 in-use IP addresses." |
|
Run Python 3.7 PostCommit |
|
PostCommit with only SpannerIO tests passed: https://ci-beam.apache.org/job/beam_PostCommit_Python37_PR/462/testReport/ |
This reverts commit a3158ea.
|
Run Python_PVR_Flink PreCommit |
Follow up of #21198
Following Python37 PostCommit integration tests on Dataflow fails after #23365.
They were not detected by the time of merging because the same tests on direct runner succeeded, and the test suite experienced timeout and did not report dataflow results, until recently (Oct 3) the test suite somehow no longer timeout.
The fail on Dataflow runner is due to mismatch of the version of cloud-spanner between pipeline construction and worker container, then no-such-module exception thrown at coder_impl at pipeline execution.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.