(BQ Java) Explicitly set coder for multi-partition batch load writes #23602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Run Java Examples_Flink |
ahmedabu98
force-pushed
the
batchloads_coder
branch
from
1dd4e47 to
2958108
Compare
Contributor
Author
|
Run Java Examples_Flink |
Contributor
Author
|
Run Java Examples_Flink |
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
Run Java PreCommit |
lostluck
approved these changes
Oct 12, 2022
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
LGTM Thanks!
Would you kindly send me a cherry pick of this to merge into the release branch?
Contributor
|
(merging after the precommit passes. The examples are in much better shape with this fix, and I acknowledge the new error is new). |
Contributor
|
Actually, looks like the precommit is done, but github didn't pick up on it. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23561 (once cherry picked into release-2.42.0)
Single partition writes set a coder
TableDestinationCoderV3here while multi partition writes doesn't set any coder explicitly, so it defaults to a serializableTableDestinationcoder. There is an attempt later to flatten the single and multi write PCollections here, but because the coder types are different, the following error is thrown:org.apache.flink.api.common.InvalidProgramException: Cannot union inputs of different types. Input1=CoderTypeInformation{coder=WindowedValue$FullWindowedValueCoder(TableDestinationCoderV2,GlobalWindow$Coder)}, input2=CoderTypeInformation{coder=WindowedValue$FullWindowedValueCoder(SerializableCoder(org.apache.beam.sdk.io.gcp.bigquery.TableDestination),GlobalWindow$Coder)}