[BEAM-220] fix flaky KafkaIO test #237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while (!reader.advance()) { | ||
| attempts++; | ||
| // very rarely will there be more than one attempts. | ||
| assertTrue("could not advance() even after 1000 attempts.", attempts < 1000); |
Contributor
There was a problem hiding this comment.
Seems like this scenario could still happen if the reader thread gets swapped out but the work thread does not.
Rather just delete this check and let test-level timeouts handle the failure case. These have a reasonable default (20s?) and maybe override it below.
Contributor
Author
There was a problem hiding this comment.
good point. 20s is test timeout is fine. I will remove the check.
Contributor
Author
|
@dhalperi addressed the comments. Please take a look. |
Contributor
|
LGTM |
Contributor
Author
|
R: @dhalperi (next time :) ) |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-core] apache#21 add builder javadocs to operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a flaky KafkaIO test.
KafkaIO reader reads from Kafka in a separate thread. As a result,
start()oradvance()might not read a record with in 10 millis timeout even from the mock kafka consumer. Updated one test that manually reads from KafkaIO reader to invokeadvance()in a loop.This should fix the flaky test. I am running these tests in a loop on my desktop to verify. One thing I can not explain is the following log from the failed jenkins build linked in BEAM-220 (the log was same when I reproduced it locally):
It is entirely clear if this is from the failed test, but
first record offset 0implies thestart()must have returned true.