[BEAM-77] Reorganize Java packages in the Google Cloud Dataflow runner #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM assuming it is green. |
Member
Author
|
This will need a new worker on the Dataflow service, before it could be merged. |
4 tasks
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and |
Member
There was a problem hiding this comment.
Comment in TestPipeline.java will now be out of date.
Java8tests module doesn't have sources, only tests. Hence, all dependencies should have scope of test. If not, dependency analysis correctly finds unused dependencies.
This is needed for package reorganization in runners/google-cloud-dataflow. Those classes will have to move away from org.apache.beam.sdk.* packages.
…runner Packages are moving from org.apache.beam.sdk to org.apache.beam.runners.dataflow.
in this pull request
davorbonaci
changed the title
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
[euphoria-spark] Add default parallelism to local mode.
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
Remove spurious Reverts section (all ancient commits unrelated to this release). Tweak markdown, language.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move packages from
org.apache.beam.sdktoorg.apache.beam.runners.dataflow.R: @bjchambers