-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Unify PerformanceTest metric dashboard naming and series #23914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @pabloem Is there a way to show the preview? Previewed locally but without actual data because had no access to the database. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Java IO dashboard also checked. Ready for review now. |
|
I am not familiar with this beyohnd the normal docs here: https://cwiki.apache.org/confluence/display/BEAM/Community+Metrics |
|
are you sure we won't need the configuration sections that you removed? are these autopopulated? |
|
Yeah, thanks. I followed this documentation and get it working except I am not using the real data from influxDB. The screenshot above shows the results of some manipulated data. The removed sections are combining read and write time in same plot as in Java. Currently they are plotted separately: http://104.154.241.245/d/gP7vMPqZz/python-io-it-tests-dataflow?orgId=1 I am working on adding more Python performance tests and this is a clean up for current frontend as a preclude. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This figure plots count instead of time. Fixed here.
|
Thanks @pabloem . Replied above. PTAL |
|
SparkReceiverIO Performance test has been merged. Rebasing and also changing the naming of it. |
|
thanks @Abacn - this LGTM : ) |

Part of #18204
Tests are named after 'IO Connector | Specifications | data size'.
Python performance tests plot read and write time in same plot as in Java
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.