Skip to content

Get postcommits green and unsickbay go test #24342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 1 commit into from
Nov 28, 2022
Merged

Get postcommits green and unsickbay go test #24342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .test-infra/jenkins/job_PostCommit_Python_Examples_Flink.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_Python_Examples_Flink',
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
tasks(":sdks:python:test-suites:portable:flinkExamplesPostCommit")
switches("-PflinkConfDir=$WORKSPACE/src/runners/flink/src/test/resources")
commonJobProperties.setGradleSwitches(delegate)
}
}
Expand Down
2 changes: 0 additions & 2 deletions sdks/go/test/integration/integration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ var portableFilters = []string{
var flinkFilters = []string{
// TODO(https://github.com/apache/beam/issues/20723): Flink tests timing out on reads.
"TestXLang_Combine.*",
// TODO(https://github.com/apache/beam/issues/21094): Test fails on post commits: "Insufficient number of network buffers".
"TestXLang_Multi",
"TestDebeziumIO_BasicRead",
// TODO(BEAM-13215): GCP IOs currently do not work in non-Dataflow portable runners.
"TestBigQueryIO.*",
Expand Down
1 change: 1 addition & 0 deletions sdks/python/apache_beam/examples/complete/tfidf_it_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@

class TfIdfIT(unittest.TestCase):
@pytest.mark.examples_postcommit
@pytest.mark.sickbay_flink
def test_basics(self):
test_pipeline = TestPipeline(is_integration_test=True)

Expand Down
1 change: 1 addition & 0 deletions sdks/python/apache_beam/examples/cookbook/bigquery_side_input_it_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def setUp(self):

@pytest.mark.no_xdist
@pytest.mark.examples_postcommit
@pytest.mark.sickbay_flink
def test_bigquery_side_input_it(self):
state_verifier = PipelineStateMatcher(PipelineState.DONE)
NUM_GROUPS = 3
Expand Down
1 change: 1 addition & 0 deletions sdks/python/apache_beam/examples/cookbook/mergecontacts_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def normalize_tsv_results(self, tsv_data):
return '\n'.join(sorted(lines_out)) + '\n'

@pytest.mark.examples_postcommit
@pytest.mark.sickbay_flink
def test_mergecontacts(self):
test_pipeline = TestPipeline(is_integration_test=True)

Expand Down
1 change: 1 addition & 0 deletions sdks/python/apache_beam/examples/cookbook/multiple_output_pardo_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def get_wordcount_results(self, result_path):
return results

@pytest.mark.examples_postcommit
@pytest.mark.sickbay_flink
def test_multiple_output_pardo(self):
test_pipeline = TestPipeline(is_integration_test=True)

Expand Down
3 changes: 0 additions & 3 deletions sdks/python/test-suites/portable/common.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,6 @@ project.tasks.register("postCommitPy${pythonVersionSuffix}IT") {
// suppress metric name collision warning logs
'\\"org.apache.flink.runtime.metrics.groups\\":\\"ERROR\\"}'
]
if (project.hasProperty('flinkConfDir')) {
pipelineOpts += ["--flink-conf-dir=${project.property('flinkConfDir')}"]
}
def cmdArgs = mapToArgString([
"test_opts": testOpts,
"suite": "postCommitIT-flink-py${pythonVersionSuffix}",
Expand Down