Skip to content

Conversation

@eantyshev
Copy link
Contributor

@eantyshev eantyshev commented Dec 14, 2022

resolves #24659

authorized CF endpoint postDeleteProgress deletes all tb_user & tb_user_progress entities related to a user
postDeleteProgress is idempotent by uid (derived from firebase ID token), which makes it possible to retry
README updated

++ small refactoring of middlewares make them less coupled (store SDK and UID in request context, not in arguments)

Should be followed by user deletion via Firebase API on the frontend side.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Dec 15, 2022
@eantyshev eantyshev marked this pull request as ready for review December 15, 2022 09:12
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@olehborysevych olehborysevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@damccorm damccorm merged commit 7c691b7 into apache:master Dec 16, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
* README

* refactor

* aio

* log

* workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tour of Beam] [Task] Delete user progress [Backend]

3 participants