[BEAM-199] Update DisplayData APIs to make overrides more understandable #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @bjchambers This PR is rather lengthy as it updates all
|
| /** | ||
| * Utility to append optional fields to display data, or register additional display data | ||
| * items. | ||
| * A display data item. DisplayData items are registered via {@link DisplayData.Builder#add} |
Contributor
There was a problem hiding this comment.
A display data item. {@link Item} items are registered via {...}
swegner
force-pushed
the
displaydata-api
branch
from
3303b25 to
19665c8
Compare
Contributor
Author
|
I've addressed all feedback so far. Please take another look. @bjchambers |
| */ | ||
| public static DisplayData from(HasDisplayData component) { | ||
| checkNotNull(component); | ||
| checkNotNull(component, "Input component cannot be null"); |
Contributor
There was a problem hiding this comment.
"component argument cannot be null"
|
|
||
| return false; | ||
| /** @see #withNamespace(Class) */ | ||
| public Item<T> withNamespace(String namespace) { |
Contributor
|
A few nits, then LGTM. |
Contributor
Author
|
I've addressed all feedback so far. Please take another look. @bjchambers |
Contributor
|
LGTM |
Contributor
Author
|
Backport: GoogleCloudPlatform/DataflowJavaSDK#230 |
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.