-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Shard Python PreCommit #24866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Shard Python PreCommit #24866
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
756c772
WIP: Support passing in special pytest args
damccorm a9b2367
Shard precommit
damccorm ca296ab
Syntax + easier testing
damccorm 4205bfb
Fix syntax
damccorm 73e27b3
Skip -> ignore
damccorm fd39e67
Fix loop
damccorm 7a98c69
Fix loop
damccorm 9b034df
Remove local testing mechanism and setup to interact with Jenkins
damccorm 467111d
Strip off any quotes
damccorm 73afffa
Strip off any quotes
damccorm 91a2b27
Strip off any quotes
damccorm 713b3bc
Strip off any quotes
damccorm 401b58f
Strip off any quotes
damccorm a62d422
Simplify arg parsing
damccorm daeeb68
Improve comment
damccorm 4f2385c
Fail on no tests run
damccorm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import PrecommitJobBuilder | ||
|
|
||
| PrecommitJobBuilder builder = new PrecommitJobBuilder( | ||
| scope: this, | ||
| nameBase: 'Python_Integration', | ||
| gradleTask: ':pythonPreCommitIT', | ||
| timeoutMins: 180, | ||
| triggerPathPatterns: [ | ||
| '^model/.*$', | ||
| '^sdks/python/.*$', | ||
| '^release/.*$', | ||
| ] | ||
| ) | ||
| builder.build { | ||
| // Publish all test results to Jenkins. | ||
| publishers { | ||
| archiveJunit('**/pytest*.xml') | ||
| } | ||
| } |
40 changes: 40 additions & 0 deletions
40
.test-infra/jenkins/job_PreCommit_Python_Dataframes.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import PrecommitJobBuilder | ||
|
|
||
| PrecommitJobBuilder builder = new PrecommitJobBuilder( | ||
| scope: this, | ||
| nameBase: 'Python_Dataframes', | ||
| gradleTask: ':pythonPreCommit', | ||
| gradleSwitches: [ | ||
| '-Pposargs=apache_beam/dataframe/' | ||
| ], | ||
| timeoutMins: 180, | ||
| triggerPathPatterns: [ | ||
| '^model/.*$', | ||
| '^sdks/python/.*$', | ||
| '^release/.*$', | ||
| ] | ||
| ) | ||
| builder.build { | ||
| // Publish all test results to Jenkins. | ||
| publishers { | ||
| archiveJunit('**/pytest*.xml') | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import PrecommitJobBuilder | ||
|
|
||
| PrecommitJobBuilder builder = new PrecommitJobBuilder( | ||
| scope: this, | ||
| nameBase: 'Python_Examples', | ||
| gradleTask: ':pythonPreCommit', | ||
| gradleSwitches: [ | ||
| '-Pposargs=apache_beam/examples/' | ||
| ], | ||
| timeoutMins: 180, | ||
| triggerPathPatterns: [ | ||
| '^model/.*$', | ||
| '^sdks/python/.*$', | ||
| '^release/.*$', | ||
| ] | ||
| ) | ||
| builder.build { | ||
| // Publish all test results to Jenkins. | ||
| publishers { | ||
| archiveJunit('**/pytest*.xml') | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import PrecommitJobBuilder | ||
|
|
||
| PrecommitJobBuilder builder = new PrecommitJobBuilder( | ||
| scope: this, | ||
| nameBase: 'Python_Runners', | ||
| gradleTask: ':pythonPreCommit', | ||
| gradleSwitches: [ | ||
| '-Pposargs=apache_beam/runners/' | ||
| ], | ||
| timeoutMins: 180, | ||
| triggerPathPatterns: [ | ||
| '^model/.*$', | ||
| '^sdks/python/.*$', | ||
| '^release/.*$', | ||
| ] | ||
| ) | ||
| builder.build { | ||
| // Publish all test results to Jenkins. | ||
| publishers { | ||
| archiveJunit('**/pytest*.xml') | ||
| } | ||
| } |
40 changes: 40 additions & 0 deletions
40
.test-infra/jenkins/job_PreCommit_Python_Transforms.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import PrecommitJobBuilder | ||
|
|
||
| PrecommitJobBuilder builder = new PrecommitJobBuilder( | ||
| scope: this, | ||
| nameBase: 'Python_Transforms', | ||
| gradleTask: ':pythonPreCommit', | ||
| gradleSwitches: [ | ||
| '-Pposargs=apache_beam/transforms/' | ||
| ], | ||
| timeoutMins: 180, | ||
| triggerPathPatterns: [ | ||
| '^model/.*$', | ||
| '^sdks/python/.*$', | ||
| '^release/.*$', | ||
| ] | ||
| ) | ||
| builder.build { | ||
| // Publish all test results to Jenkins. | ||
| publishers { | ||
| archiveJunit('**/pytest*.xml') | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is the quotes the actual cause prevented
--ignoreto work #24204 (comment) ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - it tried to parse
'--ignore=apache_beam/codersas an argument instead of theignoreflag.