[Playground][Frontend] Run timer fix; CodeRunner and OutputType extraction. #24871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: alexeyinkin <leha@inkin.ru>
Co-authored-by: alexeyinkin <leha@inkin.ru>
Contributor
Author
|
R: @alexeyinkin |
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
1 similar comment
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
damondouglas
approved these changes
Jan 14, 2023
Contributor
There was a problem hiding this comment.
@damccorm LGTM Apologies just saw merge conflicts.
damondouglas
requested changes
Jan 14, 2023
Contributor
damondouglas
left a comment
damondouglas
left a comment
There was a problem hiding this comment.
@nausharipov Resolve the merge conflicts and reassign to me. Thank you!
nausharipov
force-pushed
the
issue24617_timer_fix
branch
from
987dd9a to
cab3b15
Compare
nausharipov
force-pushed
the
issue24617_timer_fix
branch
from
cab3b15 to
d261b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24617
Resolves #24691
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.