-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Playground] Resolve issue with SCIO examples failing on start due to a timeout #24946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5c65610
Initialize SBT cache during SCIO playground container build
TSultanov 617c182
Fix issue with reading of GRPC_TIMEOUT environment variables in CI/CD…
TSultanov b42ad5b
Fix cleanup of execution environment for Scala examples
TSultanov f59bbe7
Fix panic in preparers when an empty file is passed
TSultanov 2d782c1
Use better name for SCIO project directory
TSultanov 3960bf0
Run "sbt compile" during container build to fetch all Scala dependencies
TSultanov e8689bd
Disable forking JVM in SBT to significantly reduce memory usage
TSultanov 08473d2
Impose memory limits on local deployments of SCIO runner container to…
TSultanov eecba19
Fine-tune Java GC to improve performance and memory usage of SCIO exa…
TSultanov d645408
Remove large blobs of text from common_test.go
TSultanov fd908d2
Add `sbt` to the list of development dependencies
TSultanov f02d56a
Merge remote-tracking branch 'upstream/master' into beam-24943-scio-r…
TSultanov c8900df
Clarify running of backend tests in Playground
TSultanov e127647
Clarify local running of backend
TSultanov 5e8a2de
Improve consistency in code blocks in backend Readme
TSultanov f8f6457
Merge remote-tracking branch 'upstream/master' into beam-24943-scio-r…
TSultanov bfd402e
Merge remote-tracking branch 'upstream/master' into beam-24943-scio-r…
TSultanov 4f68a76
Fixing trailing whitespace
TSultanov 6d85ebd
Merge remote-tracking branch 'upstream/master' into beam-24943-scio-r…
TSultanov dc15658
Merge remote-tracking branch 'upstream/master' into beam-24943-scio-r…
TSultanov 7ba045f
Merge remote-tracking branch 'upstream/master' into beam-24943-scio-r…
TSultanov 36e42cf
Update playground/backend/README.md
TSultanov f9dbb51
Update playground/backend/internal/utils/preparers_utils_test.go
TSultanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain again why we need mitmproxy? I read the website briefly and it looks like a networking tool. However, aren't we achieving our networking needs using kubernetes Service and other related kinds? Can our images and the Dockerfiles that describe them serve just to ship the binary?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's being used to filter out which Google Cloud Storage buckets are accessible by the examples.
However, after investigating a little bit it seems that this is not the best place to have it. We discussed this with @MakarkinSAkvelon and think that the best solution would be to have a single proxy node which would act as a reverse proxy for letting external connections to the runners and also as a single point though which runners would be able to only access the allowlisted hosts.
This approach with a single proxy node will simplify origin policy for frontend and we will be able to get rid of the need to generate
config.g.dartcompletely.This issue, however, I think, is beyond the scope of this PR and we can address it separately.