Skip to content

Conversation

@lukecwik
Copy link
Member

@lukecwik lukecwik commented Jan 18, 2023

This was added as a temporary work-around (#8322) when the XLang expansion service did not support returning additional dependencies. This removes that dependency prevent conflicts and allowing the user to control which Kafka dependency version they want to use.

For #25070


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

This was added as a temporary work-around when the XLang expansion service did not support returning additional dependencies. This removes that dependency prevent conflicts and allowing the user to control which Kafka dependency version they want to use.

Fixes apache#25070
@lukecwik
Copy link
Member Author

R: @chamikaramj @mxm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@lukecwik
Copy link
Member Author

Run Python xlang KafkaIO Performance Test

@lukecwik
Copy link
Member Author

Run XVR_Flink PostCommit

@lukecwik
Copy link
Member Author

Run Python Flink ValidatesRunner

@lukecwik
Copy link
Member Author

CC: @johnjcasey for cherry-pick into 2.45.0 release branch

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@lukecwik lukecwik merged commit 13a740b into apache:master Jan 19, 2023
lukecwik added a commit to lukecwik/incubator-beam that referenced this pull request Jan 19, 2023
…#25072)

This was added as a temporary work-around when the XLang expansion service did not support returning additional dependencies. This removes that dependency prevent conflicts and allowing the user to control which Kafka dependency version they want to use.

For apache#25070
johnjcasey pushed a commit that referenced this pull request Jan 19, 2023
)

This was added as a temporary work-around when the XLang expansion service did not support returning additional dependencies. This removes that dependency prevent conflicts and allowing the user to control which Kafka dependency version they want to use.

For #25070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants