Added MetadataSpannerConfig class for generating SpannerConfig for ac… #25193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Contributor
|
created #25383 for tracking. this PR would close it. |
Abacn
reviewed
Feb 8, 2023
Contributor
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
Sorry for the delay. Had some comments below.
...rm/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/MetadataSpannerConfig.java
Outdated
Show resolved
Hide resolved
...rm/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/MetadataSpannerConfig.java
Outdated
Show resolved
Hide resolved
...rm/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/MetadataSpannerConfig.java
Outdated
Show resolved
Hide resolved
…cessing change stream metadata database
Contributor
|
please avoid rebase unless merge conflict. this mixes review history. tests already run on feature branch merged onto master |
Contributor
|
retest this please |
Contributor
|
looks like jenkins not triggering. will try again |
Contributor
|
test failure Java_Examples_Dataflow_Java17 unrelated. merging for now. Thanks! |
nancyxu123
pushed a commit
to nancyxu123/beam
that referenced
this pull request
Mar 7, 2023
…cessing change stream metadata database (apache#25193)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up change to the quick fix that was implemented in #25108. It is a more robust solution that makes the code less brittle so that a similar config issue doesn't crop up again in the future. For details of the problem and why this solution is necessary, see #25108 (comment).