Skip to content

Test Avro extension against multiple Avro versions #25216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aromanenko-dev merged 6 commits into from
Apr 13, 2023
Merged

Test Avro extension against multiple Avro versions #25216

aromanenko-dev merged 6 commits into from
Apr 13, 2023

Conversation

@aromanenko-dev
Copy link
Contributor

@aromanenko-dev aromanenko-dev commented Jan 30, 2023

Test Avro extension against multiple Avro versions

Closes #25215

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@aromanenko-dev aromanenko-dev marked this pull request as draft January 30, 2023 14:58
@github-actions github-actions bot added the build label Jan 30, 2023
@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from 0f0010e to 9f92f61 Compare January 31, 2023 15:30
@github-actions github-actions bot added the infra label Jan 31, 2023
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Jan 31, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Jan 31, 2023

Run PostCommit_Java_Avro_Versions

@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from 9f92f61 to c6f9a11 Compare February 1, 2023 18:11
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Feb 2, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Feb 2, 2023

Run PostCommit_Java_Avro_Versions

@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from c6f9a11 to ab00f02 Compare February 7, 2023 11:20
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Feb 7, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Feb 7, 2023

Run PostCommit_Java_Avro_Versions

@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from ab00f02 to 4faec9c Compare February 9, 2023 11:59
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Feb 9, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Feb 9, 2023

Run PostCommit_Java_Avro_Versions

@aromanenko-dev aromanenko-dev mentioned this pull request Feb 15, 2023
Merged
3 tasks
@aromanenko-dev aromanenko-dev marked this pull request as ready for review March 17, 2023 17:18
@aromanenko-dev aromanenko-dev changed the title [WIP] Test Avro extension against multiple Avro versions Test Avro extension against multiple Avro versions Mar 17, 2023
@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from b4dba65 to fe5792e Compare March 17, 2023 17:32
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from fe5792e to 5b70c68 Compare March 20, 2023 11:41
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Mar 20, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Mar 20, 2023

Run PostCommit_Java_Avro_Versions

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Mar 20, 2023

@mosche could you take a look?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Mar 20, 2023

CC: @Abacn

mosche
mosche reviewed Mar 20, 2023
View reviewed changes
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 5, 2023

Run Java PreCommit

1 similar comment
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 5, 2023

Run Java PreCommit

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 6, 2023

retest this please

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 6, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 6, 2023

Run Java PreCommit

1 similar comment
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 6, 2023

Run Java PreCommit

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 6, 2023

Run Seed Job

2 similar comments
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 6, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 7, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 7, 2023

Run Java PreCommit

1 similar comment
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 7, 2023

Run Java PreCommit

@jrmccluskey
Copy link
Contributor

jrmccluskey commented Apr 10, 2023

I see that this PR is in-flight and on the 2.47.0 milestone. Do you consider this a release blocker, or can it be moved to the 2.48.0 release?

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 11, 2023

@jrmccluskey It was supposed to be merged before release cut but for some reasons it was not. I think we can move forward and leave this PR for 2.48.0 release.

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 12, 2023

Run Seed Job

@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from 4b16efd to 9ed707e Compare April 13, 2023 12:24
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 13, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 13, 2023

Run PostCommit_Java_Avro_Versions

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 13, 2023

Run Seed Job

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 13, 2023

Run Java PreCommit

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 13, 2023

Run PostCommit_Java_Avro_Versions

@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 13, 2023

Run Java_GCP_IO_Direct PreCommit

@aromanenko-dev aromanenko-dev force-pushed the avro_25215_multiple_versions branch from 9ed707e to 055187a Compare April 13, 2023 15:11
@aromanenko-dev
Copy link
Contributor Author

aromanenko-dev commented Apr 13, 2023 •
edited
Loading

Finally, it was decided to generate Avro POJOs for different Avro versions with executing avro-tools directly from Gradle tasks. We need to do the same for Avro v1.8.2 (default Beam version) in the future (if it will be still feasible).

Java PreCommit fails because it doesn't apply the extenstions/avro exclusion for JaCoCo task.

Since all other checks are passed (except Java_GCP_IO_Direct PreCommit that is flaky), I think we can move forward and merge this one to apply job_PreCommit_Java changes on Jenkins.

@aromanenko-dev aromanenko-dev merged commit 7919c3f into apache:master Apr 13, 2023
@aromanenko-dev aromanenko-dev deleted the avro_25215_multiple_versions branch April 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosche mosche mosche approved these changes

Assignees

No one assigned

Labels

build extensions infra java Next Action: Reviewers

Projects

None yet

Milestone

2.48.0 Release

Development

Successfully merging this pull request may close these issues.

[Task]: [Avro] Add support of different Avro versions for extension

3 participants

@aromanenko-dev @mosche @jrmccluskey