Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 3, 2023

Bumps github.com/testcontainers/testcontainers-go from 0.15.0 to 0.16.0.

Release notes

Sourced from github.com/testcontainers/testcontainers-go's releases.

v0.16.0

What's Changed

⚠️ Breaking Changes

  • feat: support native docker compose api (#476) @​baez90

    Docker Compose v2 is implemented in Go, and for that reason we have decided to provide native Go support to Compose, deprecating the shell-escape based LocalDockerCompose, which was invoking the local binary of compose. Given the version includes the Compose dependency, and the Docker folks added a replace directive until the upcoming Docker 22.06 release is out, we were forced to add it too, causing consumers of Testcontainers for Go to add the following replace directive too.

replace (
	github.com/docker/cli => github.com/docker/cli v20.10.3-0.20221013132413-1d6c6e2367e2+incompatible // 22.06 master branch
	github.com/docker/docker => github.com/docker/docker v20.10.3-0.20221013203545-33ab36d6b304+incompatible // 22.06 branch
	github.com/moby/buildkit => github.com/moby/buildkit v0.10.1-0.20220816171719-55ba9d14360a // same as buildx
github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.2 // Can be removed on next bump of containerd to > 1.6.4
// For k8s dependencies, we use a replace directive, to prevent them being
// upgraded to the version specified in containerd, which is not relevant to the
// version needed.
// See https://github.com/docker/buildx/pull/948 for details.
// https://github.com/docker/buildx/blob/v0.8.1/go.mod#L62-L64
k8s.io/api => k8s.io/api v0.22.4
k8s.io/apimachinery => k8s.io/apimachinery v0.22.4
k8s.io/client-go => k8s.io/client-go v0.22.4

)

  • fix: do not prepend garbage in the container.Exec response (#624) @​mdelapenya

    The signature of the Exec function on a container created by the library has been changed in what we thought it was a non-breaking change manner, using variadic arguments. But we confirmed that it could be a breaking change in the rare case where the Exec function is assigned to a variable.

// The original Exec function works here because its type is func(context.Context, []string),
// but the new Exec function’s type is func(context.Context, []string, ...ProcessOption),
// so the assignment fails at compile time. For that reason we are moving it to this section.
var execFn func(ctx context.Context, cmd []string) = myContainer.Exec

🚀 Features

  • feat: implement new MultiStrategy design (#580) @​hhsnopek

    This PR enhances how the wait.ForAll strategy behaves: it will control the startup timeout and the deadline for all inner wait strategies, using two methods: WithStartupTimeoutDefault, which sets the default timeout for all inner wait strategies; and WithDeadline, which sets a time.Duration which limits all wait strategies. As a consequence, the already existing function WithStartupTimeout has been deprecated from the multi-strategy struct.

  • feat: Auth config for build images (#602) @​paulozenida

  • feat: log docker info from compose (#591) @​mdelapenya

🐛 Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go labels Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #25294 (3d14184) into master (e659c83) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #25294   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files         746      747    +1     
  Lines       99264    99265    +1     
=======================================
+ Hits        72377    72381    +4     
+ Misses      25521    25518    -3     
  Partials     1366     1366           
Flag Coverage Δ
go 51.71% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...am/examples/inference/run_inference_side_inputs.py 36.36% <ø> (+1.36%) ⬆️
sdks/python/apache_beam/ml/inference/base.py 96.06% <ø> (-0.06%) ⬇️
...ks/go/pkg/beam/runners/prism/internal/urns/urns.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@dependabot dependabot bot force-pushed the dependabot/go_modules/sdks/github.com/testcontainers/testcontainers-go-0.16.0 branch from 1068d04 to a96138f Compare February 9, 2023 14:39
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor

Run Go PreCommit

@jrmccluskey
Copy link
Contributor

Run GoPortable PreCommit

Bumps [github.com/testcontainers/testcontainers-go](https://github.com/testcontainers/testcontainers-go) from 0.15.0 to 0.16.0.
- [Release notes](https://github.com/testcontainers/testcontainers-go/releases)
- [Commits](testcontainers/testcontainers-go@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: github.com/testcontainers/testcontainers-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/sdks/github.com/testcontainers/testcontainers-go-0.16.0 branch from a96138f to 3d14184 Compare February 9, 2023 21:20
@jrmccluskey
Copy link
Contributor

Run Go PreCommit

@jrmccluskey
Copy link
Contributor

Run GoPortable PreCommit

1 similar comment
@jrmccluskey
Copy link
Contributor

Run GoPortable PreCommit

@jrmccluskey
Copy link
Contributor

Run Go PreCommit

@jrmccluskey
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 16, 2023

Superseded by #25517.

@dependabot dependabot bot closed this Feb 16, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/sdks/github.com/testcontainers/testcontainers-go-0.16.0 branch February 16, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Next Action: Reviewers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant