Skip to content

Backlog metrics do not showing up in FlinkRunner #25554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talatuyarer wants to merge 2 commits into from
Closed

Backlog metrics do not showing up in FlinkRunner #25554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6079c55
Set MetricContext for checkpointing
Feb 19, 2023
fd383fa
Spotless Fix
Feb 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/ReaderInvocationUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.apache.beam.runners.core.metrics.MetricsContainerImpl;
import org.apache.beam.runners.flink.FlinkPipelineOptions;
import org.apache.beam.sdk.io.Source;
import org.apache.beam.sdk.io.UnboundedSource;
import org.apache.beam.sdk.metrics.MetricsEnvironment;
import org.apache.beam.sdk.options.PipelineOptions;

Expand Down Expand Up @@ -69,4 +70,18 @@ public boolean invokeAdvance(ReaderT reader) throws IOException {
return reader.advance();
}
}

public UnboundedSource.CheckpointMark invokeCheckpointMark(
UnboundedSource.UnboundedReader<OutputT> reader) throws IOException {
if (enableMetrics) {
try (Closeable ignored =
MetricsEnvironment.scopedMetricsContainer(container.getMetricsContainer(stepName))) {
UnboundedSource.CheckpointMark result = reader.getCheckpointMark();
container.updateMetrics(stepName);
return result;
}
} else {
return reader.getCheckpointMark();
}
}
}
5 changes: 4 additions & 1 deletion ...g/apache/beam/runners/flink/translation/wrappers/streaming/io/UnboundedSourceWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,9 @@ public void snapshotState(FunctionSnapshotContext functionSnapshotContext) throw
return;
}

ReaderInvocationUtil<OutputT, UnboundedSource.UnboundedReader<OutputT>> readerInvoker =
new ReaderInvocationUtil<>(stepName, serializedOptions.get(), metricContainer);
Copy link
Contributor

@je-ik je-ik Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved to a field and reused between calls to run and snapshotState.


stateForCheckpoint.clear();

long checkpointId = functionSnapshotContext.getCheckpointId();
Expand All @@ -405,7 +408,7 @@ public void snapshotState(FunctionSnapshotContext functionSnapshotContext) throw
UnboundedSource.UnboundedReader<OutputT> reader = localReaders.get(i);

@SuppressWarnings("unchecked")
CheckpointMarkT mark = (CheckpointMarkT) reader.getCheckpointMark();
CheckpointMarkT mark = (CheckpointMarkT) readerInvoker.invokeCheckpointMark(reader);
checkpointMarks.add(mark);
KV<UnboundedSource<OutputT, CheckpointMarkT>, CheckpointMarkT> kv = KV.of(source, mark);
stateForCheckpoint.add(kv);
Expand Down
Loading