Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 24, 2023

We constantly receive security alert due to the mongodb performance test instance does not have credential enabled.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Abacn
Copy link
Contributor Author

Abacn commented Feb 24, 2023

Trying to implement https://stackoverflow.com/questions/62018646/unable-to-authenticate-mongodb-deployed-in-kubernetes
the test works, but found that the k8s can still be accessed without specifying username+password, strange.

@Abacn Abacn marked this pull request as draft February 24, 2023 21:07
@Abacn
Copy link
Contributor Author

Abacn commented Mar 1, 2023

run seed job

@Abacn
Copy link
Contributor Author

Abacn commented Mar 1, 2023

Run Java MongoDBIO Performance Test

@Abacn
Copy link
Contributor Author

Abacn commented Mar 1, 2023

Run Python MongoDBIO Load Test

@Abacn
Copy link
Contributor Author

Abacn commented Mar 1, 2023

Run Python MongoDBIO Load Test

@Abacn
Copy link
Contributor Author

Abacn commented Mar 1, 2023

test passed. The current situation is that credential is enabled but the anonymous connection is still not disabled. Tried a couple of approaches still not working. Setting this PR as ready for review anyway, because

  • tests now support credentials
  • after this gets in further changes won't need to run seed job for test

@Abacn Abacn marked this pull request as ready for review March 1, 2023 04:05
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@johnjcasey johnjcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnjcasey johnjcasey merged commit 0d804d1 into apache:master Mar 7, 2023
@Abacn Abacn deleted the mongopw branch March 7, 2023 20:05
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
* Use credential for mongodb performance tests

* Set cron job freq to twice a day as for other performance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants