-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Use credential for mongodb performance tests #25631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
822914c to
cd6fe52
Compare
|
Trying to implement https://stackoverflow.com/questions/62018646/unable-to-authenticate-mongodb-deployed-in-kubernetes |
|
run seed job |
|
Run Java MongoDBIO Performance Test |
|
Run Python MongoDBIO Load Test |
|
Run Python MongoDBIO Load Test |
|
test passed. The current situation is that credential is enabled but the anonymous connection is still not disabled. Tried a couple of approaches still not working. Setting this PR as ready for review anyway, because
|
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
johnjcasey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Use credential for mongodb performance tests * Set cron job freq to twice a day as for other performance tests
We constantly receive security alert due to the mongodb performance test instance does not have credential enabled.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.