Skip to content

Conversation

@lostluck
Copy link
Contributor

@lostluck lostluck commented Mar 1, 2023

Significant further testing needs to be done before this is committed to the repo, given the importance of the datalayer in portable beam pipelines.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #25683 (5c05152) into master (b5ce110) will decrease coverage by 0.20%.
The diff coverage is 44.62%.

@@            Coverage Diff             @@
##           master   #25683      +/-   ##
==========================================
- Coverage   71.41%   71.21%   -0.20%     
==========================================
  Files         778      780       +2     
  Lines      102379   102855     +476     
==========================================
+ Hits        73112    73253     +141     
- Misses      27811    28125     +314     
- Partials     1456     1477      +21     
Flag Coverage Δ
go 53.59% <44.62%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/graph/edge.go 3.35% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/coder.go 57.68% <ø> (-0.36%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/data.go 0.00% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/timers.go 0.00% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/graphx/serialize.go 27.39% <0.00%> (-0.17%) ⬇️
sdks/go/pkg/beam/core/runtime/graphx/translate.go 37.56% <0.00%> (-0.44%) ⬇️
sdks/go/pkg/beam/core/runtime/harness/harness.go 10.93% <0.00%> (-0.09%) ⬇️
sdks/go/pkg/beam/core/funcx/fn.go 53.38% <2.94%> (-3.92%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/translate.go 23.22% <5.26%> (-0.52%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/plan.go 66.66% <11.11%> (-3.34%) ⬇️
... and 9 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 6, 2023
@lostluck
Copy link
Contributor Author

lostluck commented Jun 6, 2023

Closed since this has been merged in in other PRs.

@lostluck lostluck closed this Jun 6, 2023
@lostluck lostluck deleted the timermgr branch June 6, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant