Skip to content

Conversation

@becketqin
Copy link
Contributor

This is the second patch of migrating Flink runner to execute batch jobs with DataStream API.

This patch does the following:

  1. Add a new option of UseDataStreamForBatch. When it is set to true, the batch jobs will be executed with DataStream API. Otherwise, the jobs are executed with DataSet API.
  2. Modify the pipeline translation path to honor the configuration.
  3. Modify the tests to cover the DataStream execution path.

This patch should be merged after #25741 is resolved, so the streaming jobs metrics are still backwards compatible.

fix #25740

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Jiangjie Qin added 3 commits March 7, 2023 07:24
Modify the FlinkRunner to use DataStream API for batch job execution if
UseDataStreamForBatch is set to true.
DataStream execution path of batch jobs.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@becketqin
Copy link
Contributor Author

@xinyuiscool Would you help take a look? Thanks!!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 6, 2023
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Add UseDataStreamForBatch option to the Flink runner.

1 participant