-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Force version of sklearn in examples #25968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Python 3.9 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #25968 +/- ##
==========================================
- Coverage 71.42% 71.41% -0.01%
==========================================
Files 779 779
Lines 102530 102536 +6
==========================================
- Hits 73228 73226 -2
- Misses 27842 27850 +8
Partials 1460 1460
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| # limitations under the License. | ||
| # | ||
|
|
||
| scikit-learn==1.0.2 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will dependabot update this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure - I added a comment so that it will be obvious we should reject PRs that try to bump this.
|
Please fix lint & yapf and run an integration test suite that runs the example. |
Whoops, missed the linting failures - thanks. Python3.9 postcommit does run the example, so that's already done. I'll run it again though. |
|
Run Python 3.9 PostCommit |
Force sklearn version to the same version the models were trained on. This ensures that the examples will pass correctly.
Fixes #25967
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.