Skip to content

Conversation

@ahmedabu98
Copy link
Contributor

BigQuery xlang tests are currently in bigquery_write_it_test, so they get picked up by Python Postcommits and fail because the right environment isn't set up.

Fixes #26016

@ahmedabu98
Copy link
Contributor Author

Run Python_Xlang_Gcp_Direct PostCommit

@ahmedabu98
Copy link
Contributor Author

Run Python_Xlang_Gcp_Dataflow PostCommit

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98
Copy link
Contributor Author

R: @Abacn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Abacn
Copy link
Contributor

Abacn commented Mar 30, 2023

Xlang test suites passed:
https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Direct_PR/37/testReport/apache_beam.io.external.xlang_bigqueryio_it_test/BigQueryXlangStorageWriteIT/

https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Dataflow_PR/28/testReport/apache_beam.io.external.xlang_bigqueryio_it_test/BigQueryXlangStorageWriteIT/

beam_PreCommit_Python_Coverage_Commit fails apache_beam.runners.portability.portable_runner_test.PortableRunnerTestWithSubprocesses.test_error_message_includes_stage unrelated, other pending jobs are succeeded not updating to GitHub UI. Merging for now

@Abacn Abacn merged commit e0d8b58 into apache:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Failing Test]: Python 3.7 PostCommit failing BigQueryXlangStorageWriteIT

2 participants