Skip to content

Conversation

@AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Apr 5, 2023

Adds support for Python 3.11.

Fixes: #23848

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #26121 (c6b2800) into master (ed93a34) will decrease coverage by 0.02%.
The diff coverage is 17.64%.

@@            Coverage Diff             @@
##           master   #26121      +/-   ##
==========================================
- Coverage   71.18%   71.17%   -0.02%     
==========================================
  Files         787      787              
  Lines      103296   103311      +15     
==========================================
- Hits        73530    73529       -1     
- Misses      28278    28294      +16     
  Partials     1488     1488              
Flag Coverage Δ
python 79.85% <17.64%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/internal/dill_pickler.py 77.91% <6.66%> (-7.23%) ⬇️
sdks/python/apache_beam/__init__.py 85.00% <100.00%> (ø)
...apache_beam/runners/dataflow/internal/apiclient.py 77.02% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva
Copy link
Contributor Author

Run Python_Integration PreCommit

@tvalentyn
Copy link
Contributor

Verified that this PR is identical to #26120 modulo comment-only changes to base_image_requirements_manual.txt.

@tvalentyn
Copy link
Contributor

Merging based on test signal from #26120

@tvalentyn tvalentyn marked this pull request as ready for review April 5, 2023 19:42
@tvalentyn tvalentyn merged commit 87db1ae into apache:master Apr 5, 2023
@tvalentyn tvalentyn changed the title Python 3.11 support with dill monkey patching Support Python 3.11 (#26121) Apr 5, 2023
Comment on lines +50 to +55
tasks(':sdks:python:test-suites:portable:py${lowestSupported}:preCommitPy${lowestSupported}')
commonJobProperties.setGradleSwitches(delegate)
}
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
tasks(':sdks:python:test-suites:portable:py310:preCommitPy310')
tasks(':sdks:python:test-suites:portable:${highestSupported}:preCommitPy${highestSupported}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these changes are causing Python Portable Precommit to fail with:

Project 'py${lowestSupported}' not found in project ':sdks:python:test-suites:portable'

Need to use double quotes when using embedded values

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in #26151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Python 3.11

3 participants