Rename _namespace to _get_display_data_namespace #26353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26353 +/- ##
==========================================
+ Coverage 71.21% 71.85% +0.64%
==========================================
Files 787 752 -35
Lines 103330 101477 -1853
==========================================
- Hits 73588 72921 -667
+ Misses 28246 27060 -1186
Partials 1496 1496
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 47 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Run PythonLint PreCommit |
Contributor
Author
|
R: @tvalentyn |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
tvalentyn
approved these changes
Apr 20, 2023
svetakvsundhar
added a commit
to svetakvsundhar/beam
that referenced
this pull request
Apr 26, 2023
This reverts commit 080eef0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20907
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.