Skip to content

Revert "Add explicit language_level=3 arg to Cythonize" #26414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tvalentyn wants to merge 1 commit into from
Closed

Revert "Add explicit language_level=3 arg to Cythonize" #26414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
# It is recommended to import setuptools prior to importing distutils to avoid
# using legacy behavior from distutils.
# https://setuptools.readthedocs.io/en/latest/history.html#v48-0-0
from distutils.errors import DistutilsError # isort:skip
from distutils.errors import DistutilsError # isort:skip


class mypy(Command):
Expand Down Expand Up @@ -127,7 +127,6 @@ def get_version():
try:
# pylint: disable=wrong-import-position
from Cython.Build import cythonize as cythonize0

def cythonize(*args, **kwargs):
import numpy
extensions = cythonize0(*args, **kwargs)
Expand All @@ -151,7 +150,6 @@ def cythonize(*args, **kwargs):
'pandas>=1.4.3,!=1.5.0,!=1.5.1,<1.6;python_version>="3.8"',
]


# We must generate protos after setup_requires are installed.
def generate_protos_first():
try:
Expand Down Expand Up @@ -213,6 +211,7 @@ def get_portability_package_data():
]
},
ext_modules=cythonize([
# Make sure to use language_level=3 cython directive in files below.
'apache_beam/**/*.pyx',
'apache_beam/coders/coder_impl.py',
'apache_beam/metrics/cells.py',
Expand All @@ -225,7 +224,7 @@ def get_portability_package_data():
'apache_beam/transforms/stats.py',
'apache_beam/utils/counters.py',
'apache_beam/utils/windowed_value.py',
], language_level=3),
]),
install_requires = [
'crcmod>=1.7,<2.0',
'orjson<4.0',
Expand Down