-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Cherry-pick: Add driverJars parameter to JdbcIO. (#25824) #26474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change allows users to use driver jars saved in GCS. With this change, Dataflow templates will be able to migrate to JdbcIO instead of DynamicJdbcIO.
|
R: @jrmccluskey |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## release-2.47.0 #26474 +/- ##
==================================================
- Coverage 71.17% 70.55% -0.62%
==================================================
Files 787 787
Lines 103294 103311 +17
==================================================
- Hits 73518 72896 -622
- Misses 28287 28926 +639
Partials 1489 1489
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Run Python_Integration PreCommit |
|
Possibly related: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Python311/105/ Update: yes it is related. Kicked off the test in this cherry-pick PR and test also fails: https://ci-beam.apache.org/job/beam_PostCommit_Python311_PR/17/consoleFull |
|
Run Python 3.11 PostCommit |
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java
Outdated
Show resolved
Hide resolved
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java
Show resolved
Hide resolved
* Fix jdbc xlang schema type mismatch * Also fix fetch_size type mismatch * Add new fields in the end
|
Run Python 3.11 PostCommit |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
|
Run Python 3.11 PostCommit |
|
Run Python_Integration PreCommit |
|
I'm not anticipating this PR significantly impacting the Python tests I'm re-running, will merge after those have any result |
|
Dataflow tests are flaky recently due to no worker available in us-central1 region. |
|
That would explain the flakey failures I've been seeing on streaming integration tests. Thank you for the context! |
Cherry-picking #25824 to the release.