Skip to content

Conversation

@bvolpato
Copy link
Contributor

Cherry-picking #25824 to the release.

This change allows users to use driver jars saved in GCS. With this change, Dataflow templates will be able to migrate to JdbcIO instead of DynamicJdbcIO.
@github-actions github-actions bot added the io label Apr 28, 2023
@bvolpato
Copy link
Contributor Author

R: @jrmccluskey

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #26474 (dbaa8dc) into release-2.47.0 (4d1f1f1) will decrease coverage by 0.62%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release-2.47.0   #26474      +/-   ##
==================================================
- Coverage           71.17%   70.55%   -0.62%     
==================================================
  Files                 787      787              
  Lines              103294   103311      +17     
==================================================
- Hits                73518    72896     -622     
- Misses              28287    28926     +639     
  Partials             1489     1489              
Flag Coverage Δ
python 78.94% <ø> (-0.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/jdbc.py 79.16% <ø> (ø)

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jrmccluskey
Copy link
Contributor

Run Python_Integration PreCommit

@Abacn
Copy link
Contributor

Abacn commented Apr 28, 2023

Possibly related: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Python311/105/

Update: yes it is related. Kicked off the test in this cherry-pick PR and test also fails: https://ci-beam.apache.org/job/beam_PostCommit_Python311_PR/17/consoleFull

15:24:41 FAILED                                                                   [ 75%]
15:24:41 apache_beam/io/external/xlang_jdbcio_it_test.py::CrossLanguageJdbcIOTest::test_xlang_jdbc_write_read_1_mysql 

@Abacn
Copy link
Contributor

Abacn commented Apr 28, 2023

Run Python 3.11 PostCommit

* Fix jdbc xlang schema type mismatch

* Also fix fetch_size type mismatch

* Add new fields in the end
@bvolpato
Copy link
Contributor Author

Updated with patch provided by @Abacn at #25062. Thanks Yi.

@bvolpato bvolpato requested a review from Abacn April 29, 2023 01:51
@Abacn
Copy link
Contributor

Abacn commented Apr 29, 2023

Run Python 3.11 PostCommit

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jrmccluskey
Copy link
Contributor

Run Python 3.11 PostCommit

@jrmccluskey
Copy link
Contributor

Run Python_Integration PreCommit

@jrmccluskey
Copy link
Contributor

I'm not anticipating this PR significantly impacting the Python tests I'm re-running, will merge after those have any result

@Abacn
Copy link
Contributor

Abacn commented Apr 29, 2023

Dataflow tests are flaky recently due to no worker available in us-central1 region.

@jrmccluskey
Copy link
Contributor

That would explain the flakey failures I've been seeing on streaming integration tests. Thank you for the context!

@jrmccluskey jrmccluskey merged commit 0f12dfd into apache:release-2.47.0 Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants