Skip to content

Conversation

@TSultanov
Copy link
Contributor

@TSultanov TSultanov commented May 4, 2023

Toru of Beam Gradle file with deployment tasks and Gradle files with Playground docker containers build definitions had been executing actions during Gradle init. This resulted in unwanted file copies and attempts to contact remote servers during, for example, project load in ItelliJ Idea.

  • Removed intiialization-time actions in ToB deployment build definitions
  • Removed initialization-time actions in Playground containers build definitions
  • Reorganized ToB deployment script to use dependsOn instead of relying on mustRunAfter

resolves #26528


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@TSultanov TSultanov marked this pull request as ready for review May 4, 2023 14:07
Copy link
Contributor

@olehborysevych olehborysevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@damccorm damccorm merged commit dd6f5b0 into apache:master May 8, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
…zation time (apache#26544)

* Fix initialization-time execution of tasks which should only be executed fruing build time

* Fix initialization-time execution of tasks which should only be executed fruing build time for Playground containers build

* Use dependsOn to specify dependency graph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tour of Beam Terraform automation appears break gradle build

3 participants