beam-wide: blacklist Throwables.propagate and remove uses #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| <exclusion> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava-jdk5</artifactId> | ||
| </exclusion> |
Contributor
Author
There was a problem hiding this comment.
This change is because we imported the wrong version of Throwables (from API client) and thus removed this dependency.
[INFO] --- maven-surefire-plugin:2.18.1:test (runnable-on-service-tests) @ direct-runner ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-dependency-plugin:2.10:analyze-only (default) @ direct-runner ---
[WARNING] Unused declared dependencies found:
[WARNING] com.google.http-client:google-http-client:jar:1.21.0:compile
[INFO] ------------------------------------------------------------------------
Member
|
LGTM |
Contributor
Author
|
Thanks! Will merge after I fixup the tests. |
dhalperi
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
May 2, 2016
This is a partial backport of apache/beam#270
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward-port of GoogleCloudPlatform/DataflowJavaSDK#232